[Webkit-unassigned] [Bug 51764] [GTK] Port stock icon painting to GtkStyleContext

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51764


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77798|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #6 from Xan Lopez <xan.lopez at gmail.com>  2011-01-04 04:15:29 PST ---
(From update of attachment 77798)
View in context: https://bugs.webkit.org/attachment.cgi?id=77798&action=review

r- in case we can avoid searching twice.

> WebCore/platform/gtk/RenderThemeGtk3.cpp:85
> +

GtkWidgetPath could possibly be added to our GOwnPtr stuff at some point.

> WebCore/platform/gtk/RenderThemeGtk3.cpp:91
> +    return iter->second.get();

Instead of doing contains() + find() I think you could just do one find() and then check that the iter is valid. Seems pointless to search twice?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.