[Webkit-unassigned] [Bug 51861] DataView.getInt8() returns unsigned value on ARM platform

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51861





--- Comment #4 from Xianzhu Wang <wangxianzhu at google.com>  2011-01-04 02:06:46 PST ---
(In reply to comment #2)
> (From update of attachment 77863 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77863&action=review
> 
> > WebCore/bindings/js/JSDataViewCustom.cpp:139
> > +        imp->setInt8(byteOffset, static_cast<signed char>(value), ec);
> 
> Does setInt8 take a signed char explictly?  it seems it should.  Does the compiler warn about this sign conversion?  Again, it seems it should.
> 
> > WebCore/html/canvas/DataView.h:59
> > +    void setInt8(unsigned byteOffset, signed char value, ExceptionCode&);
> 
> Ah, I see you're making ti signed here.  don't we have a less-verbose type to use than "signed char"?  int8_t or similar?

Thanks for review.
Changed signed char to int8_t, and also types of other methods to more precise integer types.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.