[Webkit-unassigned] [Bug 51474] [Qt][WK2] Incomplete clean up on termination

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51474





--- Comment #18 from Kenneth Rohde Christiansen <kenneth at webkit.org>  2011-01-03 13:28:30 PST ---
(From update of attachment 77816)
View in context: https://bugs.webkit.org/attachment.cgi?id=77816&action=review

> WebKit2/ChangeLog:10
> +        Do not try to cleanup on crash because it is ont reliable.

not*

> WebKit2/ChangeLog:14
> +        do not own that. This is the case of a server connection.

s/that/it. s/of/with/

> WebKit2/ChangeLog:16
> +        Making MappedMemoryPool a QObject so the CleanupHandler can destruct it

Turn MappedMemoryPool into a ...

> WebKit2/Platform/qt/MappedMemoryPool.cpp:45
> +        // Do not leave mapping files on the disk!

s/!/.

> WebKit2/Platform/qt/SharedMemoryQt.cpp:102
> +    // Do not leave behind the shared memory segment.

move behind to the end. Do not leave the shared memory segment behind.

> WebKit2/Platform/qt/SharedMemoryQt.cpp:139
> +    // Do not leave behind the shared memory segment.

same here

> WebKit2/Shared/qt/CleanupHandler.cpp:41
> +    QCoreApplication* coreApplication = QCoreApplication::instance();

Maybe you can use qApp instead? just wondering...

> WebKit2/Shared/qt/CleanupHandler.h:63
> +    static void sigTermHandler(int);

Is this one still needed?

> WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:90
> +    // Do not leave behind the socket file.

move behind to the end.

> WebKit2/UIProcess/Launcher/qt/ProcessLauncherQt.cpp:102
> +        static bool registered = false;

isRegistered would be slightly more WebKitish

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.