[Webkit-unassigned] [Bug 51736] Implement RemoteFontStream's skip behavior (in FontCustomPlatformData.cpp)

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51736





--- Comment #5 from Xianzhu Wang <wangxianzhu at google.com>  2011-01-02 19:31:17 PST ---
(In reply to comment #4)
> (From update of attachment 77666 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77666&action=review
> 
> > WebCore/platform/graphics/skia/FontCustomPlatformData.cpp:153
> >          if (!m_buffer->data() || !m_buffer->size())
> 
> I'm confused.  Your'e removing a null check of buffer, yet using buffer unconditionally?

The condition is now at line 157 of the new file. The 'read' and 'skip' features only differ at line 158.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.