[Webkit-unassigned] [Bug 51115] Crash in web process after the connection had been closed

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51115





--- Comment #14 from Balazs Kelemen <kbalazs at webkit.org>  2011-01-02 19:05:40 PST ---
(In reply to comment #13)
> (From update of attachment 77057 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=77057&action=review
> 
> I’d like to review, but I’d like to hear from Anders whether he thinks this is the right solution.
> 
> > WebKit2/ChangeLog:8
> > +        Add mutual exclusion for m_client.
> 
> Typically for a single pointer we could use a function like the Mac OS X OSAtomicCompareAndSwapPtrBarrier instead of a mutex. I don’t know if that’s desirable here or not.

I don't have a strong opinion about that. However, if we want atomic 
functionality then I think it should be introduced into WTF for all platforms.

> 
> > WebKit2/Platform/CoreIPC/Connection.cpp:342
> > -    if (!m_client)
> > +    if (!isValid())
> 
> Is this better? Generally speaking if code is going to be manipulating m_client directly, I am not sure that isValid is providing a helpful abstraction inside the Connection class.

Yes, maybe just saying |!m_client| is more straightforward here.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.