[Webkit-unassigned] [Bug 51601] WML Parser should treat line/column number in a consistent way

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51601


Joone Hur <joone at kldp.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77584|0                           |1
        is obsolete|                            |
  Attachment #77785|                            |review?, commit-queue?
               Flag|                            |




--- Comment #10 from Joone Hur <joone at kldp.org>  2011-01-02 17:16:05 PST ---
Created an attachment (id=77785)
 --> (https://bugs.webkit.org/attachment.cgi?id=77785&action=review)
Proposed Patch4

Fixed the DRT test fail.

XML Parser reports only the first parsing error even if there are many errors on the same line.
However, the latest patch reports all errors on the same line, so I fixed the patch as follows,

bool operator==(const TextPosition& other) { return m_line == other.m_line && m_column == other.m_column; }
bool operator!=(const TextPosition& other) { return !((*this) == other); }

=> 

bool operator==(const TextPosition& other) { return m_line == other.m_line && m_column == other.m_column; }
bool operator!=(const TextPosition& other) { return m_line != other.m_line && m_column != other.m_column; }

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.