[Webkit-unassigned] [Bug 48031] AffineTransform operator* reverses order of operands.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48031


Dirk Schulze <krit at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #76578|review?                     |review-
               Flag|                            |




--- Comment #16 from Dirk Schulze <krit at webkit.org>  2011-01-02 11:23:59 PST ---
(From update of attachment 76578)
View in context: https://bugs.webkit.org/attachment.cgi?id=76578&action=review

The patch looks good in general, but I'd prefer to use multiply and postMultiply where ever possible. Another question, would it make sense to rename multiply with preMultiply corresponding to postMultiply?

r- for the questions above and the wrong comment style.

> WebCore/platform/graphics/transforms/AffineTransform.cpp:170
> +/**
> + * Multiplies this AffineTransform by the provided AffineTransform - i.e.
> + * this = this * other;
> + */

Comments with //

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.