[Webkit-unassigned] [Bug 51789] Don't include Inspector headers when Inspector is disabled

Sun Jan 2 01:33:51 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=51789

--- Comment #9 from Konstantin Tokarev <annulen at yandex.ru>  2011-01-02 01:33:51 PST ---
(In reply to comment #6)
> This reason in particular change seems wrong to me. Changing which other headers are included indirectly is only likely to break no-inspector builds more often, and has no positive effect that I could see.

In perspective I'd like to introduce option for building WebKit without JavaScript engine. It's needed for running WebKit on device with very limited memory and storage. This patch is really a first step in this way, because inspector #includes bring JavaScript engine dependencies in some sources which don't relly use it.

I'm afraid this change will be out of your scope. However, I'd like to help you with making WebKit more configurable and easier to shrink, also making my local modifications as small as it's possible

Please look through these patch. I really cannot see anything that it may break. Patch just disables one or two headers in each of modified files, and shrinks unused inspector cookies is some places. Not so big change, as it may seem.

>I thought that the preferred approach was to have #include guards in headers, not in every .cpp file.

I'm afraid shrinking header may break compilation of no-inspector builds on platforms which I don't test.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.