[Webkit-unassigned] [Bug 51789] Don't include Inspector headers when Inspector is disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51789





--- Comment #7 from Darin Adler <darin at apple.com>  2011-01-01 19:52:20 PST ---
(In reply to comment #6)
> I thought that the preferred approach was to have #include guards in headers, not in every .cpp file. Is that wrong?

Probably right. We have a mix of both techniques, and I forgot what is the approved way.

> > leading to transitive inclusion of other unrelated headers
> 
> This reason in particular change seems wrong to me. Changing which other headers are included indirectly is only likely to break no-inspector builds more often, and has no positive effect that I could see.

I agree with you on this, Alexey.

Sorry I didn’t think of these things before approving the patch.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.