[Webkit-unassigned] [Bug 51789] Don't include Inspector headers when Inspector is disabled

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=51789


Alexey Proskuryakov <ap at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ap at webkit.org,
                   |                            |darin at apple.com




--- Comment #6 from Alexey Proskuryakov <ap at webkit.org>  2011-01-01 13:21:09 PST ---
I thought that the preferred approach was to have #include guards in headers, not in every .cpp file. Is that wrong?

> leading to transitive inclusion of other unrelated headers

This reason in particular change seems wrong to me. Changing which other headers are included indirectly is only likely to break no-inspector builds more often, and has no positive effect that I could see.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.