[Webkit-unassigned] [Bug 48511] [GTK] Implement Process/Thread Launcher classes and WebProcessGtkMain for WebKit2

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48511





--- Comment #6 from Ravi Phaneendra Kasibhatla <ravi.kasibhatla at motorola.com>  2011-01-01 12:45:22 PST ---
(In reply to comment #4)
> (From update of attachment 72686 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=72686&action=review
> 
> Looks good! Some comments below.
> 
> > WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:55
> > +    String commandLine(WEBKIT_WEB_PROCESS_PATH);
> 
> I don't understand why you are using a String here. Why not just use WEBKIT_WEB_PROCESS_PATH below?
Used String object just to be in WebKit usage pattern (for datatypes). Anyways I have modified code to actually pick the WebKitWebProcess binary from same folder in which current binary resides.

> 
> > WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:68
> > +        ASSERT_NOT_REACHED();
> > +    }
> 
> I think it's better to try to handle the error here somehow, even if it's just printing a message.
I am not sure what error handling can be done here, so just added a print statement (as you suggested).
> 
> > WebKit2/UIProcess/Launcher/gtk/ProcessLauncherGtk.cpp:81
> > +    notImplemented();
> 
> Is this not implemented or simply an empty implementation?
Its an empty implementation right now. Corrected it.
> 
> > WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:43
> > +    // FIXME: Implement.
> 
> This looks like a good place for notImplemented() :) I think this file is also missing stubs for platformShutdown and platformClearResourceCaches.
> 
Done.
> > WebKit2/WebProcess/gtk/WebProcessMainGtk.cpp:54
> > +    g_type_init();
> 
> Do you also need to call g_thread_init() here? Only after 2.24 does g_type_init() call g_thread_init().
Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.