[Webkit-unassigned] [Bug 51789] Don't include Inspector headers when Inspector is disabled

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sat Jan 1 08:33:57 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=51789


Darin Adler <darin at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #77740|review?, commit-queue?      |review-, commit-queue-
               Flag|                            |




--- Comment #2 from Darin Adler <darin at apple.com>  2011-01-01 08:33:57 PST ---
(From update of attachment 77740)
View in context: https://bugs.webkit.org/attachment.cgi?id=77740&action=review

> WebCore/bindings/js/JSDOMWindowBase.cpp:34
> +
> +#if ENABLE(INSPECTOR)
>  #include "InspectorController.h"
> +#endif
> +

Conditional includes should go in separate paragraphs after the unconditional includes, not sorted in the middle of the unconditional includes.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list