[Webkit-unassigned] [Bug 55115] Create IDLs for DataTransferItems

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Feb 28 18:09:47 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=55115





--- Comment #9 from Daniel Cheng <dcheng at chromium.org>  2011-02-28 18:09:47 PST ---
(In reply to comment #5)
> (From update of attachment 83624 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=83624&action=review
> 
> Seems a bit silly to add non-compiled code.  Especially since you didn't add any .cpp files even.

I wasn't sure how to split up the change. For the most part, I think each implementation would be highly platform-specific.

> 
> > Source/WebCore/dom/DataTransferItem.h:41
> > +class DataTransferItem : public RefCounted<DataTransferItem> {
> 
> Shouldn't this header be conditional?
> 

Done.

> > Source/WebCore/dom/DataTransferItems.h:43
> > +class DataTransferItems : public RefCounted<DataTransferItems> {
> 
> Wrapped in #ifs?

Done.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list