[Webkit-unassigned] [Bug 26838] Multithread support for JSC on UNIX

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=26838


Martin Robinson <mrobinson at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84154|review?                     |review+
               Flag|                            |




--- Comment #16 from Martin Robinson <mrobinson at webkit.org>  2011-02-28 17:07:22 PST ---
(From update of attachment 84154)
View in context: https://bugs.webkit.org/attachment.cgi?id=84154&action=review

Okay, with the few fixes I mentioned. This needs to be cleaned up, but the GTK+ bots are dying in a bloody heap at the moment.

> Source/JavaScriptCore/runtime/MachineStackMarker.cpp:74
> +#if USE(PTHREADS)

Please use if !OS(WINDOWS) && !OS(DARWIN) && USE(PTHREADS) here as well.

> Source/JavaScriptCore/runtime/MachineStackMarker.cpp:77
> +#define SA_RESTART 0

Probably should just "#error MachineStackMarker requires SA_RESTART" (or something nicer sounding) here. I don't think 0 is actually a working replacement.

> Source/JavaScriptCore/runtime/MachineStackMarker.cpp:124
> +        struct sigaction act;

act -> action

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.