[Webkit-unassigned] [Bug 55095] IndexedDB: fire versionchange events when calling setVersion

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55095





--- Comment #7 from David Grogan <dgrogan at chromium.org>  2011-02-28 12:44:32 PST ---
(From update of attachment 83570)
View in context: https://bugs.webkit.org/attachment.cgi?id=83570&action=review

>> LayoutTests/storage/indexeddb/set_version_queue.html:71
>> +    versionChangeNotifications.push("connection " + connectionNum +
> 
> no need to wrap..and you could maybe just put it in the closure above?

done

>> Source/WebCore/storage/IDBDatabaseBackendImpl.cpp:50
>> +    int connectionId() { return m_connectionId; }
> 
> newline before private..

done

>> Source/WebCore/storage/IDBDatabaseBackendImpl.cpp:218
>> +void IDBDatabaseBackendImpl::open(int connectionId, PassRefPtr<IDBDatabaseCallbacks> callbacks)
> 
> You should just have one version of this function.  And it should simply take in the PassRefPtr

done

>> Source/WebCore/storage/IDBDatabaseBackendImpl.cpp:229
>> +void IDBDatabaseBackendImpl::close(int connectionId)
> 
> This should take in an IDBDatabaseCallbacks ptr...and assert it's there before you remove it.

done

>> Source/WebCore/storage/IDBDatabaseBackendImpl.h:101
>> +    int m_nextId;
> 
> no longer necessary

done

>> Source/WebCore/storage/IDBDatabaseCallbacks.h:34
>> +#include "SerializedScriptValue.h"
> 
> not needed...you likely will need PlatformString. if you delete tho.

done

>> Source/WebCore/storage/IDBRequest.cpp:154
>> +
> 
> extra newline

done

>> Source/WebKit/chromium/public/WebIDBDatabaseCallbacks.h:38
>> +
> 
> no newlines

done

>> Source/WebKit/chromium/src/IDBDatabaseCallbacksProxy.h:55
>> +
> 
> no double newline

done

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.