[Webkit-unassigned] [Bug 55307] fast/frames/iframe-plugin-load-remove-document-crash.html crashing in PluginView::didFail since it was added

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55307





--- Comment #11 from Abhishek Arya <inferno at chromium.org>  2011-02-28 12:41:38 PST ---
(In reply to comment #9)
> (From update of attachment 84093 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=84093&action=review
> 
> > Source/WebCore/plugins/PluginView.cpp:960
> > +    if (m_manualStream)
> 
> Please add a comment stating why m_manualStream can be null here.

Added it in the changelog - "This can happen when we run pending document onload events during plugin load that remove the frame from underneath.". Probably not good to put in code since we are thinking about the option of asynchronous load events for plugins, just like what media element does. so, this comment won't be valid then.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.