[Webkit-unassigned] [Bug 48127] [Qt][WK2] Plugin initialization

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=48127


Anders Carlsson <andersca at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84079|review?                     |review-
               Flag|                            |




--- Comment #57 from Anders Carlsson <andersca at apple.com>  2011-02-28 11:13:34 PST ---
(From update of attachment 84079)
View in context: https://bugs.webkit.org/attachment.cgi?id=84079&action=review

I'm going to go ahead and mark this as r- because it didn't build on Windows. Please upload a new patch and I'll r+ it.

> Source/WebKit2/Shared/Plugins/PluginQuirks.h:42
> +        RequiresGTKToolKit,

Please add a comment to this quirk that explain what it's for and why it's necessary.

> Source/WebKit2/WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:490
> +               *reinterpret_cast<uint32_t*>(value) = 2;

Please add a comment explaining what "2" means here, or maybe put it in a constant.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.