[Webkit-unassigned] [Bug 54811] REGRESSION(r78383): Failure to connect on websocketstest.com

Mon Feb 28 02:33:00 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=54811

Yuta Kitamura <yutak at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|REGRESSION: Failure to      |REGRESSION(r78383): Failure
                   |connect on                  |to connect on
                   |websocketstest.com          |websocketstest.com
                 CC|                            |abarth at webkit.org,
                   |                            |eric at webkit.org

--- Comment #3 from Yuta Kitamura <yutak at chromium.org>  2011-02-28 02:33:00 PST ---
I did bisect this regression and found that the revision caused this regression is r78383.
http://trac.webkit.org/changeset/78383

SocketStreamHandle for CF (WebCore/platform/network/SocketStreamHandleCFNet.cpp) calls KURL::setPort() in its constructor (line 73) and tries to make sure the port number (":80" or ":443") is always included in the host part.

After r78383, KURL::setPort() no longer appends the port part if you specify the default port number for a given scheme. That's why SocketStreamHandle has regressed.

I'm not sure if the current usage of setPort() in SocketStreamHandle is valid or not. I'd like to hear Eric and Adam's opinion about this.

If SocketStreamHandle needs a fix, I think I can do it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.