[Webkit-unassigned] [Bug 55202] Add missing length units to CSS unit category function

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55202


Ojan Vafai <ojan at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |ojan at chromium.org




--- Comment #4 from Ojan Vafai <ojan at chromium.org>  2011-02-27 20:09:59 PST ---
(In reply to comment #3)
> If this is the case, then I reckon that CSS_EMS, CSS_EXS and CSS_REMS should be added to the default case of the switch so they explicitly return UOther, to make it clearer that this is intended, and not a simple omission.

I'd rather see asserts at the top of unitCategory explicitly checking for these types. For now, I'll r- this patch since it seems the existing code is correct, albeit confusing. (right?)

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.