[Webkit-unassigned] [Bug 52267] Change results.json format to the one used by unexpected_results.json

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=52267





--- Comment #13 from Ojan Vafai <ojan at chromium.org>  2011-02-27 19:51:36 PST ---
(From update of attachment 83778)
View in context: https://bugs.webkit.org/attachment.cgi?id=83778&action=review

>> Tools/Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:174
>> +    def generator_full_results_file(self):
> 
> Nit: Maybe generate_full_results_file to match generate_json_output?

whoops. just a typo.

>> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner.py:115
>> +        keywords[v] = k.upper()
> 
> Nit: k -> modifier? v-> code_string?  Even key, value would be better.

Sorry. Was just mimicking the code above. Will fix both.

>> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner.py:151
>> +            tests[test]['time'] = int(1000 * time_seconds)
> 
> Can we name the dict key time_ms to make the units clear?

yes.

>> Tools/Scripts/webkitpy/layout_tests/layout_package/test_runner.py:820
>> +        # actual --> a
> 
> In a future patch, maybe we can just zip the file.  I bet you get a > 20% savings.

The downside is that we'd have to unzip it on the receiving end since we're ultimately serving up a JS file to the browser.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.