[Webkit-unassigned] [Bug 55330] New: [Qt] [WK2] QGraphicsWKView::showContextMenu() should be public

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Feb 27 13:47:51 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=55330

           Summary: [Qt] [WK2] QGraphicsWKView::showContextMenu() should
                    be public
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: Qt, QtTriaged
          Severity: Normal
          Priority: P3
         Component: WebKit2
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: benjamin.poulain at nokia.com


I originally made QGraphicsWKView::showContextMenu() private because I considered the users could just make their own slot and cut the connection to the existing slot.

However, the implementation of the menu is non trivial due to the possibility of multiple call from the WebProcess. I now think the method should be accessible to implementors so they have an easy way to handle those corner case by calling the original method with their own menu.

(and I added some doc so it is mentioned somewhere the menu can be empty, that cannot hurt :))

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list