[Webkit-unassigned] [Bug 55307] fast/frames/iframe-plugin-load-remove-document-crash.html crashing in PluginView::didFail since it was added

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55307


Abhishek Arya <inferno at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |abarth at webkit.org
              Group|                            |Security-Sensitive




--- Comment #4 from Abhishek Arya <inferno at chromium.org>  2011-02-27 10:02:53 PST ---
How does everyone feel the idea of changing

   ASSERT(m_manualStream); 
    m_manualStream->didFail(0, error);

to
    if (m_manualStream)
         m_manualStream->didFail(0, error);


since it does not look like we ever get a chance to get plugin response before we try to fail with error. we execute the load events while plugin document loader is doing processing.

void PluginView::didReceiveResponse(const ResourceResponse& response)
{
    if (m_status != PluginStatusLoadedSuccessfully)
        return;

    ASSERT(m_loadManually);
    ASSERT(!m_manualStream);

    m_manualStream = PluginStream::create......

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.