[Webkit-unassigned] [Bug 48234] Size of text in popup menu doesn't match size of text in <select> itself in WebKit2
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Sat Feb 26 20:01:08 PST 2011
https://bugs.webkit.org/show_bug.cgi?id=48234
--- Comment #3 from mitz at webkit.org 2011-02-26 20:01:08 PST ---
(From update of attachment 83960)
View in context: https://bugs.webkit.org/attachment.cgi?id=83960&action=review
> Source/WebKit2/ChangeLog:6
> + https://bugs.webkit.org/show_bug.cgi?id=48234
<rdar://problem/8589450>
> Source/WebKit2/ChangeLog:13
> + Add class to encapsulate passing a font description over the wire.
Why isn’t it called FontDescription, then?
> Source/WebKit2/Shared/PlatformPopupMenuData.cpp:32
> +
Whitespace
> Source/WebKit2/Shared/PlatformPopupMenuData.h:39
> +
Here too
> Source/WebKit2/UIProcess/WebPageProxy.cpp:33
> #include "DrawingAreaProxy.h"
> +#include "DictionaryPopupInfo.h"
Not in ASCII order.
> Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.h:53
> + void populate(const Vector<WebPopupItem>&, NSFont*, WebCore::TextDirection);
Missing space after “NSFont”
> Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:51
> +void WebPopupMenuProxyMac::populate(const Vector<WebPopupItem>& items, NSFont* font, TextDirection menuTextDirection)
Ditto. Also extra space before “font”.
> Source/WebKit2/UIProcess/mac/WebPopupMenuProxyMac.mm:94
> + NSFont *font = nil;
No need to initialize this to nil.
--
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
More information about the webkit-unassigned
mailing list