[Webkit-unassigned] [Bug 31507] REGRESSION: [CAIRO] wrong drawing of Gradients and Patterns on texts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=31507





--- Comment #6 from Benjamin Otte <otte at gnome.org>  2011-02-26 14:51:03 PST ---
View in context: https://bugs.webkit.org/attachment.cgi?id=83948&action=review

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:146
> +    cairo_push_group(cr);

please add:
cairo_set_operator(cr, CAIRO_OPERATOR_SOURCE);

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:173
> +            reduceSourceByAlpha(cr, globalAlpha);

Maybe add a FIXME here to add a function for reducing color of gradients manually? As I said yesterday, you can create a new gradient pattern with the same colorstops reduced by global alpha.

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:180
> +    }

I'd factor out lines 163-180 into a common function to be called from here and prepareForStroking.

> Source/WebCore/platform/graphics/cairo/GraphicsContextCairo.cpp:226
> +    cairo_restore(cr);

Is this correct now that we do global alpha in setPlatformFill()?
This should just be a cairo_fill(), no?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.