[Webkit-unassigned] [Bug 44797] fullscreen javascript bindings not implemented for v8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44797





--- Comment #20 from David Dorwin <ddorwin at chromium.org>  2011-02-26 11:12:53 PST ---
(In reply to comment #19)
> (In reply to comment #18)
> > Broke Chromium Windows:
> > http://build.webkit.org/builders/Chromium%20Win%20Release/builds/19456/steps/compile-webkit/logs/stdio
> 
> I don't think this is a real failure after all.  It's failing on build.webkit.org but building fine on build.chromium.org.  We need to investigate what's happening though.

I think a clobber of the WebKit Chromium bots should resolve this. Looking at the build output, Document.cpp was not rebuilt even though the value of ENABLE_FULLSCREEN_API changed in Source/WebKit/chromium/features.gypi. The new value is being picked up in ChromeClientImpl.cpp, causing ChromeClientImpl::exitFullScreenForElement() to be compiled.

The full Chromium build still has ENABLE_FULLSCREEN_API=0 until I check in the corresponding Chromium CL.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.