[Webkit-unassigned] [Bug 55257] Support creating compositing layers for scrollable and overflowing objects

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55257





--- Comment #3 from James Robinson <jamesr at chromium.org>  2011-02-25 15:52:15 PST ---
(From update of attachment 83890)
View in context: https://bugs.webkit.org/attachment.cgi?id=83890&action=review

> Source/WebCore/rendering/RenderLayer.cpp:3816
> +        || isComposited();

Why do you need to change this logic?  It doesn't seem like this patch should change this logic.

> Source/WebCore/rendering/RenderLayerCompositor.cpp:-1206
> -    return m_hasAcceleratedCompositing && layer->isSelfPaintingLayer();

Why do you need to change this?

> Source/WebCore/rendering/RenderLayerCompositor.cpp:1305
> +        FrameView* frameView = m_renderView->frameView();
> +        // Some sites use tiny iframes to load hidden content, so don't composite those.
> +        if (frameView->layoutWidth() <= 1 || frameView->layoutHeight() <= 1)
> +            return false;

This feels awkward - is not redundant with the check at 1309-1310?

> Source/WebCore/rendering/RenderLayerCompositor.h:244
>      // Whether a running transition or animation enforces the need for a compositing layer.
> +    bool requiresCompositingForScrollableOverflow(RenderObject*) const;

This comment seems out of date now.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.