[Webkit-unassigned] [Bug 54774] [fileapi] Implement LocalFileSystem.resolveFileSystemURI

Fri Feb 25 15:14:08 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=54774

Adam Barth <abarth at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83844|review?                     |review+
               Flag|                            |

--- Comment #20 from Adam Barth <abarth at webkit.org>  2011-02-25 15:14:08 PST ---
(From update of attachment 83844)
View in context: https://bugs.webkit.org/attachment.cgi?id=83844&action=review

>> Source/WebCore/fileapi/DOMFileSystemBase.cpp:62
>> +    KURL originURL(ParsedURLString, url.path());
> 
> Note that though I've switched to completeURL() below, I haven't here.  Is there any other URL-parsing code I should be calling? I can't really guarantee anything about the contents of url.path() (certainly not that it's the output of KURL::string()).  But passing in a Document and calling completeURL() here is obviously the wrong thing to do.

Yeah, this case is harder.  You can try resolving it against a base URL of "about:blank".  This is probably also ok for now.  I suspect we'll need to revisit this line of code when we start deploying the URLString type more widely.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.