[Webkit-unassigned] [Bug 54912] Minimize calls to ubrk_setText()

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54912





--- Comment #52 from Darin Adler <darin at apple.com>  2011-02-25 10:33:55 PST ---
(From update of attachment 83775)
View in context: https://bugs.webkit.org/attachment.cgi?id=83775&action=review

Some comments about slight improvements. These could wait until afterward, though. I do not mean to reverse Mitz’s review+ with these.

> Source/WebCore/platform/text/TextBreakIterator.h:61
> +class LazyLineBreakIterator {

Should probably mark this non-copyable with the macro.

> Source/WebCore/platform/text/TextBreakIterator.h:79
> +    TextBreakIterator* get()

I’d prefer a noun name for this rather than a verb. Maybe iterator().

> Source/WebCore/platform/text/TextBreakIteratorICU.cpp:86
> +        bool createdNewLineBreakIterator = false;
> +        setUpIterator(createdNewLineBreakIterator, lineBreakIterator, UBRK_LINE, string, length);

I think the local variable should have a name that makes it clear it’s not the same as the global. And why.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.