[Webkit-unassigned] [Bug 53146] [GTK] Combo boxes should emit object:selection-changed even when collapsed

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 25 02:01:21 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=53146


Mario Sanchez Prada <msanchez at igalia.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #82943|0                           |1
        is obsolete|                            |
  Attachment #83786|                            |review?
               Flag|                            |




--- Comment #13 from Mario Sanchez Prada <msanchez at igalia.com>  2011-02-25 02:01:20 PST ---
Created an attachment (id=83786)
 --> (https://bugs.webkit.org/attachment.cgi?id=83786&action=review)
Patch proposal + Layout test

Ok, here we go again... strike 3!

I've changed the code, once again, this time to directly compare the list object currently used with the list object used before, so if they're not the same we assume further comparisons make no sense. Semantically it's the same than asking for the parentObject() of a listBox option object, but without having to call oldFocusedObject->parentObject(), which was what was causing the failure before.

I've tested locally and couldn't reproduce crashes anymore. Also Philippe (who was able to reproduce the crashes always in a more reliable way) tested this new patch and confirms he doesn't get crashes anymore, so I hope this time will be "the good one (tm)"

Sorry for the hassle.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list