[Webkit-unassigned] [Bug 55209] New: Remove support for Node::willRemove()

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 25 01:04:08 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=55209

           Summary: Remove support for Node::willRemove()
           Product: WebKit
           Version: 528+ (Nightly build)
          Platform: PC
        OS/Version: Mac OS X 10.5
            Status: NEW
          Severity: Normal
          Priority: P2
         Component: New Bugs
        AssignedTo: webkit-unassigned at lists.webkit.org
        ReportedBy: eric at webkit.org
                CC: abarth at webkit.org, aestes at apple.com


Remove support for Node::willRemove()

It slows down performance of moving/removing nodes.   This shows up in peacekeeper's domDynamicCreationCreateElement (as well as other benchmarks I'm sure).

There was only 1 usage (HTMLFrameOwnerElement::willRemove()) until recently.  Now we have HTMLSourceElement::willRemove().  Both should easily be able to be removed.

On my local copy of peacekeeper's domDynamicCreationCreateElement:

Before:
avg 366.3333333333333
median 366
stdev 2.712112747574399
min 362
max 377

After removing willRemove():
avg 350.23333333333335
median 349
stdev 4.200661323596031
min 347
max 370

I got those by commenting out willRemove().  Now I'm going to investigate actually getting rid of it.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list