[Webkit-unassigned] [Bug 55072] Make OpenGL implementation of the GraphicsContext3D class shareable

Fri Feb 25 00:54:56 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=55072

--- Comment #2 from Zan Dobersek <zandobersek at gmail.com>  2011-02-25 00:54:56 PST ---
Created an attachment (id=83783)
 --> (https://bugs.webkit.org/attachment.cgi?id=83783&action=review)
Modifying the Extensions3DOpenGL class

As discussed with Kenneth on IRC, Gtk port cannot foresee what extensions functions the drivers will be able to offer. By using phrase 'extensions functions' I mean _every_ function that can be extensible (for instance glIsProgramARB, glUniform1fARB, glBlitFramebufferEXT etc). Therefor Gtk port is planning to go through a list of these functions and try loading every function with possible extension suffix through glXGetProcAddress.

Because of that it is necessary to move calls to OpenGL extensions functions out of the GraphicsContext3D class in order to make it usable to the Gtk port as well.

This patch recommends adding further extensions functions to the Extensions3DOpenGL class that would then be implemented separately in the Gtk and Mac port. The patch offers a bare file with basic implementation for the latter, but I'm not sure whether this would be a .mm or a .cpp file (not familiar with the Mac build system). Changes to the GraphicsContext3D class are not included, but it would basically come down to replacing calls to any extensions function with m_extensions->function().

Seeing this just now, the recently added vertex array extensions functions should probably also be branched out into separate files as implementing them on the Gtk port would probably need a different approach.

This patch is of illustrative nature and would welcome opinions on this approach, so no ChangeLog entries were generated and a license header is also missing from the new file.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.