[Webkit-unassigned] [Bug 54707] Introduce lookup-table based approach for applying CSS properties.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54707





--- Comment #19 from Eric Seidel <eric at webkit.org>  2011-02-24 16:20:54 PST ---
(From update of attachment 83735)
View in context: https://bugs.webkit.org/attachment.cgi?id=83735&action=review

> Source/WebCore/css/CSSStyleApplyProperty.cpp:210
> +void CSSStyleApplyProperty::initial(int property, CSSStyleSelector* instance)

Can't property be type specific (an enum) instead of int?  Or do we not currently use an enum for these?

> Source/WebCore/css/CSSStyleApplyProperty.cpp:213
> +    ASSERT_VALID_PROPERTY(property);
> +    m_propertyMap[PROPERTY_INDEX(property)]->initial(instance);

Seems this lookup is repeated.  The ASSERT and PROPERTY_INDEX call, etc. could all be rolled into a lookup:
propertyValue(property)->initial(instance);
would then be all this needed to look like.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.