[Webkit-unassigned] [Bug 54915] Remove unused JPEGImageEncoder code

Thu Feb 24 13:02:38 PST 2011

https://bugs.webkit.org/show_bug.cgi?id=54915

--- Comment #16 from Peter Kasting <pkasting at google.com>  2011-02-24 13:02:38 PST ---
(In reply to comment #15)
> (In reply to comment #14)
> > Seems most ports either leave it unimplemented or rely on (graphics)platform feature. skia port is using a PNG encoder in image-encoders/skia. The jpeg/png encoders in image-encoders are platform independent, and can provide a shared implementation for other ports.
> 
> Based on http://trac.webkit.org/changeset/75488 the Skia ports are using image-encoders/skia for JPEG too.

Is there a compelling reason to choose a platform-dependent versus platform-independent implementation?  It seems like in principle it would be better to be consistent: either change various ports to all use the common code or have the OpenVG port (or whatever) use a mechanism more similar to the other ports.

I have no idea how this stuff works so I can't say which is better.  I'm biased towards cross-platform implementations if they don't come with disadvantages, though.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.