[Webkit-unassigned] [Bug 54926] All Console Messages should be passed to ChromeClients.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54926





--- Comment #15 from Joseph Pecoraro <joepeck at webkit.org>  2011-02-24 10:10:15 PST ---
> While const is more correct, none of the other extern NSStrings in
> WebKit have const. Just drop the const.

I modelled this after WebViewDidBeginEditingNotification in WebView.{h,mm}
which is extern const, and does line up the strings. But I'm fine with reverting
them to the prevailing style.

> > Source/WebKit/mac/WebCoreSupport/WebChromeClient.mm:433
> > +        selector = @selector(webView:addMessageToConsole:);
> > +        if (![delegate respondsToSelector:selector])
> > +            return;
> > +        // The old selector only takes JSMessageSource messages.
> > +        if (source != JSMessageSource)
> > +            return;
> 
> You should flip the order here. You shouldn't ask if it responds to the
> selector unless you plan to call it. That will match the old behavior.
> (Checking the source first is faster too.)

Good point, Done.

> > Source/WebKit/mac/WebView/WebUIDelegatePrivate.h:142
> > +    @method webView:addMessageToConsole
> 
> This is the wrong method name.

Arg, good catch. Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.