[Webkit-unassigned] [Bug 54926] All Console Messages should be passed to ChromeClients.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54926





--- Comment #11 from David Kilzer (ddkilzer) <ddkilzer at webkit.org>  2011-02-24 09:25:57 PST ---
(In reply to comment #10)
> (In reply to comment #7)
> > (In reply to comment #3)
> > > (From update of attachment 83257 [details] [details] [details])
> > > What about adding a shouldDumpConsoleMessages? or similar to the DRT? I especially
> > > do not think we should dump console messages together with the render tree output.
> > > Alternatively, it could be part of the text dumping.
> > 
> > I gave this a shot, and it turns out plenty of tests already have console message output
> > even if they aren't dumpAsText. This includes the inspector/ tests, numerous in
> > svg/custom and svg/hixie. It was more than 25 tests. I think it'll be best to leave
> > this aspect alone or file a separate bug on that.
> 
> A follow-up bug sounds fine to handle the new test results after adding the delegate method to DRT.

I misread the original message.  I guess Kenneth can comment on whether this should be fixed separately.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.