[Webkit-unassigned] [Bug 55057] Web Inspector: refactor inspect() workflow so that it did not push dom nodes.

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=55057





--- Comment #6 from Pavel Feldman <pfeldman at chromium.org>  2011-02-24 06:26:35 PST ---
(From update of attachment 83546)
View in context: https://bugs.webkit.org/attachment.cgi?id=83546&action=review

>> Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp:174
>> +#if ENABLE(DATABASE)
> 
> Should be 2 lines above?

No, this is a bug fix since these methods are called from within Javascript unconditionally. I actually fixed callframes as well.

>> Source/WebCore/bindings/js/JSInjectedScriptHostCustom.cpp:186
>> +#if ENABLE(DOM_STORAGE)
> 
> same here

ditto

>> Source/WebCore/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:218
>>      if (args.Length() < 1)
> 
> Why is this not under the #if guard below?

ditto

>> Source/WebCore/inspector/InjectedScript.cpp:182
>> +        function.appendArgument(InjectedScriptHost::nodeAsScriptValue(mainWorldScriptState(frame), node));
> 
> You should give the state from the m_injectedScriptObject, shouldn't you?

Done.

>> Source/WebCore/inspector/InjectedScriptSource.js:70
>> +        if (arguments.length === 0)
> 
> What is this check for? If you need to check whether the object is valid you should check it explicitely.

This is correct - I should be able to inspect and dump undefined, null, etc. This check did not change.

>> Source/WebCore/inspector/InspectorDatabaseResource.cpp:41
>> +static long nextUnusedId = 1;
> 
> What's the reason for this change?

Consistency. All ids are 1-based longs.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.