[Webkit-unassigned] [Bug 54380] [Qt]tst_QWebPage::modified() asserts

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54380


Andreas Kling <kling at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83098|review?, commit-queue?      |review-
               Flag|                            |




--- Comment #4 from Andreas Kling <kling at webkit.org>  2011-02-24 04:59:53 PST ---
(From update of attachment 83098)
View in context: https://bugs.webkit.org/attachment.cgi?id=83098&action=review

r- because we should implement QWebFrame::setUrl() in a cleaner way.

> Source/WebKit/qt/Api/qwebframe.cpp:765
> +    // Resetting the load type here can be removed, if resetting
> +    // happens at end of every load or abort
> +    d->frame->loader()->resetLoadType();
>      d->frame->loader()->activeDocumentLoader()->writer()->begin(absolute);
>      d->frame->loader()->activeDocumentLoader()->writer()->end();

I have a feeling that we're doing something wrong here (way too many ->'s..)

The difference between QWebFrame::setUrl() and QWebFrame::load() is that setUrl() should clear the frame immediately, instead of when the new page has content. There must be a cleaner way than reaching all the way down to the writer(). FrameLoader::clear() perhaps?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.