[Webkit-unassigned] [Bug 53591] print-vse-failure-logs: "Found 0 VSE Build Logs" and "WebKit/WebKitBuild/obj" is not there

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=53591


Eric Seidel <eric at webkit.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83414|review?                     |review-
               Flag|                            |




--- Comment #13 from Eric Seidel <eric at webkit.org>  2011-02-24 02:55:06 PST ---
(From update of attachment 83414)
View in context: https://bugs.webkit.org/attachment.cgi?id=83414&action=review

How do we test this?  We have unit testing for Python and perl, seems we should use it.

> Tools/Scripts/build-webkit:590
> +            if ($configuration eq 'Debug') {
> +                system(File::Spec->catfile($scriptDir, "print-vse-failure-logs"), '--debug');
> +            } else {
> +                system(File::Spec->catfile($scriptDir, "print-vse-failure-logs"), '--release');
> +            }

I'm pretty sure that wkdirs.pm has a function for returning --debug or --release from the $configuration information.

> Tools/Scripts/print-vse-failure-logs:126
> +    elif len(sys.argv) == 2:
> +        if sys.argv[1] != "--release" and sys.argv[1] != "--debug":
> +            usage()
> +        option = sys.argv[1]

Seems we should consider using optparse.  It's very easy to do.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.