[Webkit-unassigned] [Bug 54876] Web Inspector: [Text editor] Bug in the highlighter

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54876


Pavel Feldman <pfeldman at chromium.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83302|review?                     |review-
               Flag|                            |




--- Comment #5 from Pavel Feldman <pfeldman at chromium.org>  2011-02-24 02:38:17 PST ---
(From update of attachment 83302)
View in context: https://bugs.webkit.org/attachment.cgi?id=83302&action=review

This looks good. r- for timeout, as we agreed.

> LayoutTests/inspector/editor/highlighter-long-line.html:30
> +        function() {

"{" on the next line.

function()
{
}

> LayoutTests/inspector/editor/highlighter-long-line.html:47
> +        function() {

ditto

> LayoutTests/inspector/editor/highlighter-paste-in-comment.html:24
> +        function() {

ditto (and below)

> LayoutTests/inspector/editor/highlighter-test.js:22
> +InspectorTest.waitForAllTimeouts = function(runnable, callback)

As we agreed, let's change the source code API for better testability.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.