[Webkit-unassigned] [Bug 44329] SH4 JIT SUPPORT

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44329


Nikolas Zimmermann <zimmermann at kde.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83614|review?                     |review-
               Flag|                            |




--- Comment #67 from Nikolas Zimmermann <zimmermann at kde.org>  2011-02-24 01:15:57 PST ---
(From update of attachment 83614)
View in context: https://bugs.webkit.org/attachment.cgi?id=83614&action=review

Almost there, can you upload another one fixing my few nitpicks, I'll r+/cq+ it.

> Source/JavaScriptCore/ChangeLog:5
> +        cacheFlush for SH4.

Provide an ExecutableAllocater::cacheFlush() implementation for Linux/SH4.

> Source/JavaScriptCore/jit/ExecutableAllocator.h:321
> +

One newline too much.

> Source/JavaScriptCore/jit/ExecutableAllocator.h:327
> +        syscall(__NR_cacheflush, reinterpret_cast<unsigned int>(code), size, CACHEFLUSH_D_WB | CACHEFLUSH_I | CACHEFLUSH_D_L2);
> +#else
> +        syscall(__NR_cacheflush, reinterpret_cast<unsigned int>(code), size, CACHEFLUSH_D_WB | CACHEFLUSH_I);

s/unsigned int/unsigned/

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.