[Webkit-unassigned] [Bug 53705] Viewport parsing no longer accepts "1.0; " value as valid.

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 23:39:29 PST 2011


Joseph Pecoraro <joepeck at webkit.org> changed:

           What    |Removed                     |Added
  Attachment #83228|0                           |1
        is obsolete|                            |
  Attachment #83612|                            |review?, commit-queue-
               Flag|                            |

--- Comment #25 from Joseph Pecoraro <joepeck at webkit.org>  2011-02-23 23:39:28 PST ---
Created an attachment (id=83612)
 --> (https://bugs.webkit.org/attachment.cgi?id=83612&action=review)
[PATCH] Add didReadNumber to see if toFloat / toDecimal to clarify if "ok" means garbage at end

I might as well do this right!

Much cleaner from the Viewport side of things. "ok" is false if there was any
error, and didReadNumber is true is there was ever a numeric value parsed.

Valid values also include scientific notation, so "1e3" is valid for 100.
I tested this with a bunch of numbers and prefixes +1, -1, .5, etc, and
it looked good.

Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the webkit-unassigned mailing list