[Webkit-unassigned] [Bug 54774] [fileapi] Implement LocalFileSystem.resolveFileSystemURI

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54774





--- Comment #10 from Kinuko Yasuda <kinuko at chromium.org>  2011-02-23 20:58:36 PST ---
(From update of attachment 83404)
The FS part is looking good.

View in context: https://bugs.webkit.org/attachment.cgi?id=83404&action=review

> Source/WebCore/fileapi/FileSystemCallbacks.cpp:248
> +    if (m_successCallback) {

I think we do not need m_successCallback check here (and line 225 above).  If the user only provides errorCallback (it doesn't make sense but technically possible) the current code doesn't work as expected.
(Or we can skip the entire operation if neither callbacks are given, as it's read-only operation.)


As for readFileSystem, no I don't think there's any other call site. We used to have some code for devtools but the code was reverted due to devtool code refactoring.
If you're going to upload another patch please feel free to drop the size parameter.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.