[Webkit-unassigned] [Bug 47593] Require a user gesture to open the file dialog

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=47593


Andy Estes <aestes at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|55110                       |




--- Comment #22 from Andy Estes <aestes at apple.com>  2011-02-23 18:17:07 PST ---
(In reply to comment #21)
> Johnny, while looking into this I noticed that the test for this patch passes even if I comment out the early return in RenderFileUploadControl::click(). This isn't so great :(
> 
> I was thinking about how to make this test more obvious, and I think the right thing to do is to have DumpRenderTree implement the UI delegates for the open panel (webView:runOpenPanelForFileButtonWithResultListener:allowMultipleFiles: and webView:runOpenPanelForFileButtonWithResultListener on the Mac) and have them log a message. Layout test expectations could then be based around the presence/absence of this log message.
> 
> That technique could be useful for this test as well as for the tests that will be necessary for the two dependent bugs.

I filed <https://bugs.webkit.org/show_bug.cgi?id=55110> about this.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.