[Webkit-unassigned] [Bug 53696] Caret is rendered at an incorrect position at the boundary of Arabic number in a LTR context

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 17:52:53 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=53696





--- Comment #16 from Ryosuke Niwa <rniwa at webkit.org>  2011-02-23 17:52:53 PST ---
(In reply to comment #9)
> (From update of attachment 81318 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=81318&action=review
> 
> > Source/WebCore/dom/Position.cpp:1123
> > +                InlineBox* prevBox = inlineBox;
> > +                do {
> > +                    if (prevBox->bidiLevel() < level) {
> > +                        inlineBox = prevBox;
> > +                        caretOffset = inlineBox->caretRightmostOffset();
> > +                        break;
> > +                    }
> > +                    prevBox = prevBox->prevLeafChild();
> > +                } while (prevBox);
> 
> Is there a reason not to write this as a for() loop?

Very good point.  Fixed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list