[Webkit-unassigned] [Bug 44797] fullscreen javascript bindings not implemented for v8

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=44797





--- Comment #3 from Darin Fisher (:fishd, Google) <fishd at chromium.org>  2011-02-23 14:55:53 PST ---
(From update of attachment 83411)
View in context: https://bugs.webkit.org/attachment.cgi?id=83411&action=review

I only reviewed the WebKit/chromium changes.

> Source/WebKit/chromium/public/WebSettings.h:114
> +    virtual void setFullScreenEnabled(bool) = 0;

LGTM for this WebKit API change.

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:872
> +    // TODO(ddorwin): We may need to call these someplace else when window resizes.

TODO(ddorwin) -> FIXME

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:879
> +    // TODO(ddorwin): We may need to call these someplace else when window resizes.

ditto

> Source/WebKit/chromium/src/ChromeClientImpl.cpp:886
> +    // TODO(ddorwin): Implement.

ditto

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.