[Webkit-unassigned] [Bug 37769] [Gtk] Flash item placed on wrong location right after load

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=37769


Xan Lopez <xan.lopez at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83539|review?                     |review+
               Flag|                            |




--- Comment #6 from Xan Lopez <xan.lopez at gmail.com>  2011-02-23 13:57:20 PST ---
(From update of attachment 83539)
View in context: https://bugs.webkit.org/attachment.cgi?id=83539&action=review

Since the patch seems to clearly improve some broken cases I guess we can go for it, but honestly we should either improve our tests or stop messing with this code.

> Source/WebCore/plugins/gtk/PluginViewGtk.cpp:534
> +        *(m_delayedAllocation.get()) = allocation;

Can't we just store a 'GtkAllocation' in the struct and copy the values? Seems more straightforward.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.