[Webkit-unassigned] [Bug 23668] CSS 'content' attribute does not work with window.getComputedStyle

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=23668


Simon Fraser (smfr) <simon.fraser at apple.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #83526|review+                     |review-
               Flag|                            |




--- Comment #8 from Simon Fraser (smfr) <simon.fraser at apple.com>  2011-02-23 13:40:33 PST ---
(From update of attachment 83526)
View in context: https://bugs.webkit.org/attachment.cgi?id=83526&action=review

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:730
> +static PassRefPtr<CSSValue> contentToCSSValue(PassRefPtr<RenderStyle> style)

The argument can be a const RenderStyle*

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:748
> +static PassRefPtr<CSSValue> counterToCSSValue(PassRefPtr<RenderStyle> style, int propertyID)

Ditto.

> Source/WebCore/css/CSSComputedStyleDeclaration.cpp:852
> +        case CSSPropertyBackgroundRepeatX:
> +            return CSSPrimitiveValue::create(style->backgroundRepeatX());
> +        case CSSPropertyBackgroundRepeatY:
> +            return CSSPrimitiveValue::create(style->backgroundRepeatY());

There are no individual CSS properties for background-repeat-x and y (http://www.w3.org/TR/css3-background/#the-background-repeat), so I don't think we should be supporting computed style for them.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.