[Webkit-unassigned] [Bug 54986] deprecatedEditingOffset should actually return the expected deprecated value for "after" positions

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Feb 23 12:40:51 PST 2011


https://bugs.webkit.org/show_bug.cgi?id=54986





--- Comment #20 from Eric Seidel <eric at webkit.org>  2011-02-23 12:40:51 PST ---
(From update of attachment 83509)
View in context: https://bugs.webkit.org/attachment.cgi?id=83509&action=review

This was never intended to work.  But if this makes your transition job easier I guess it's OK.

> Source/WebCore/dom/Position.cpp:151
> +    ASSERT(m_anchorType == PositionIsAfterAnchor && !m_isLegacyEditingPosition);

Aren't these two redundant?  Also generally we try to have one ASSERT per line as that makes it easier to see from the debug traces which one failed.

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.



More information about the webkit-unassigned mailing list