[Webkit-unassigned] [Bug 54820] REGRESSION: Knob of a disabled range control is draggable

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54820





--- Comment #3 from Dimitri Glazkov (Google) <dglazkov at chromium.org>  2011-02-23 12:32:12 PST ---
(In reply to comment #2)
> looks like this fixes it.  how does one write a layout test for such a thing ?
> 
> 
> Index: Source/WebCore/html/shadow/SliderThumbElement.cpp
> ===================================================================
> --- Source/WebCore/html/shadow/SliderThumbElement.cpp    (revision 78999)
> +++ Source/WebCore/html/shadow/SliderThumbElement.cpp    (working copy)
> @@ -158,6 +158,12 @@
>          return;
>      }
> 
> +    HTMLInputElement* input = static_cast<HTMLInputElement*>(shadowHost());
> +    if (input->isReadOnlyFormControl() || !input->isEnabledFormControl() ) {
> +        HTMLDivElement::defaultEventHandler(event);
> +        return;
> +    }
> + 
>      MouseEvent* mouseEvent = static_cast<MouseEvent*>(event);
>      bool isLeftButton = mouseEvent->button() == LeftButton;
>      const AtomicString& eventType = event->type();

There are lots of examples in existing LayoutTests. For example:

http://google.com/codesearch/p#OAMlx_jo-ck/src/third_party/WebKit/LayoutTests/fast/repaint/slider-thumb-drag-release.html&exact_package=chromium

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.