[Webkit-unassigned] [Bug 54807] Always explicitly use "signed" keyword to declare signed bitfields

[bugzilla-daemon at webkit.org]

https://bugs.webkit.org/show_bug.cgi?id=54807





--- Comment #17 from Alexey Proskuryakov <ap at webkit.org>  2011-02-23 11:19:23 PST ---
(From update of attachment 83495)
View in context: https://bugs.webkit.org/attachment.cgi?id=83495&action=review

Looks good to me. Since I'm not normally working on either side of this code, deferring review to others.

> Source/JavaScriptCore/assembler/ARMAssembler.h:254
> +            unsigned m_used : 1;

Could it be a bool?

> Source/JavaScriptCore/assembler/ARMv7Assembler.h:532
> +        unsigned m_used : 1;

Ditto.

> Source/JavaScriptCore/assembler/MIPSAssembler.h:207
> +        unsigned m_used : 1;

Ditto.

> Source/JavaScriptCore/assembler/X86Assembler.h:262
>          bool m_used : 1;

This one is a bool!

> Source/JavaScriptCore/bytecode/StructureStubInfo.h:144
> +        unsigned seen : 1;

Could this be a bool, too?

-- 
Configure bugmail: https://bugs.webkit.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.